Add a utility function to GeometryOpsCore, to get geometries from any data structure #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a generic utility inspired by similar functions in Rasters.jl and elsewhere - returns a vector of the geometries in a given object, be it a feature collection, table, iterable of geometries, or whatever. Potential next steps: - `get_geometries(x) do geom` that rebuilds the given structure as far as possible - this is the same as `apply(::AbstractGeometryTrait)` though.... - treatment of dataframes with multiple columns
rafaqz
approved these changes
Nov 25, 2024
| elseif Tables.istable(x) && Tables.hascolumn(x, first(GI.geometrycolumns(x))) | ||
| return Tables.getcolumn(x, first(GI.geometrycolumns(x))) | ||
| else | ||
| c = collect(x) |
There was a problem hiding this comment.
Probably want to skip this if x is already an AbstractArray, you can have a do nothing condition
rafaqz
reviewed
Nov 25, 2024
| if GI.isgeometry(x) | ||
| return x | ||
| # elseif GI.isgeometrycollection(x) | ||
| # return GI.getgeom(x) |
There was a problem hiding this comment.
This would need collect, and needs to be checked first
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a generic utility inspired by similar functions in Rasters.jl and elsewhere - returns a vector of the geometries in a given object, be it a feature collection, table, iterable of geometries, or whatever.
Potential next steps:
get_geometries(x) do geomthat rebuilds the given structure as far as possible - this is the same asapply(::AbstractGeometryTrait)though....Also: do we want this here? in GeoInterface?